search

compose-x / ecs_composex

Manage, Configure and Deploy your services and AWS services and applications from your docker-compose definitions
https://docs.compose-x.io
Mozilla Public License 2.0
158 stars 16 forks source link

ECS.ContainerDefinition.StopTimeout docker-compose.service.stop_grace_period #718

Closed thorfi closed 7 months ago

thorfi commented 7 months ago

Set ECS.ContainerDefinition.StopTimeout from docker-compose.service.stop_grace_period

Fixes #717

thorfi commented 7 months ago

Hi @JohnPreston ,

I tried to stick to naming/logging conventions as far as I understand them, but let me know if anything needs tweaking before you merge.

Thanks!

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

JohnPreston commented 7 months ago

@thorfi can you please fix the indentation/formatting with black? For future ease you your end, use pre-commit

python3 -m pip install pip -U; python -m pip install pre-commit
cd ecs_composex; pre-commit install

That way pre-commit will trigger when you do git commit and auto correct anything it can.

thorfi commented 7 months ago

@thorfi can you please fix the indentation/formatting with black? For future ease you your end, use pre-commit

Done! Thanks