search

composer / installers

A Multi-Framework Composer Library Installer
MIT License
1.43k stars 412 forks source link

Review list of installers and which one are still needed #477

Closed Seldaek closed 3 years ago

Seldaek commented 3 years ago

If we do a 2.0 release, we should make sure any installers which are not needed anymore get cleaned up. This will require a community effort though as we have no clue about most of the projects having custom installers here.

If you know of one which needs breaking changes or could be removed as it's unnecessary, please say so here. You can find the complete list in the README.

Already known/planned to be removed are:

Also noteworthy to most people reading this is that we are looking to improve even further the data available at runtime for users of Composer 2 (or 2.1+ in this case), which probably should help the use case of applications registering extensions dynamically at runtime: https://github.com/composer/composer/issues/9648

greg-1-anderson commented 3 years ago

Drupal should be removed or updated. I didn't make an issue on drupal.org yet, but I started a discussion in Slack.

brandonkelly commented 3 years ago

CraftInstaller is safe to remove. That hasn’t been needed since Craft 3.0.

Cheddam commented 3 years ago

SilverStripeInstaller is definitely still required, particularly for themes.

marc1706 commented 3 years ago

PhpBBInstaller is still needed

Tobion commented 3 years ago

Symfony1 installer can probably be removed by now

mbabker commented 3 years ago

You can most likely drop JoomlaInstaller, the app itself isn't distributed in a Composer-supported manner and there is a community plugin which does more to install extensions into Joomla in the way the application requires them added.

nickveenhof commented 3 years ago

I wouldn't remove the Drupal one, many projects still depend on that and it would break massively imho? Unless there is a drupal composer plugin, but this doesn't seem to be official according to this search: https://github.com/drupal?q=composer&type=&language=&sort=

GaryJones commented 3 years ago

The WordPress ones are still needed.

lukasbestle commented 3 years ago

Kirby is also planned to be removed: https://github.com/composer/installers/pull/485

Seldaek commented 3 years ago

Ok now removed for the upcoming 2.0:

We still have a long list of supported platforms, of which I assume many are dead and buried by now, but I don't really have time to go through each one by one so I guess we'll leave it at that.

Seldaek commented 3 years ago

https://github.com/composer/installers/releases/tag/v2.0.0-alpha1 is now available for testing. Please someone test this and confirm things are good? :) I'd aim to make it a final release in a week or two depending on feedback.

aimeos commented 3 years ago

You can also remove installer for Aimeos as we use the composer InstalledVersions::getPackageByType() method now.

Seldaek commented 3 years ago

@aimeos thanks - done in https://github.com/composer/installers/commit/0a9a8dd9a3eb0387d2961bfffd77842dd4fdd08f