search

composer / semver

Semantic versioning utilities with the addition of version constraints parsing and checking.
MIT License
3.15k stars 76 forks source link

nit on missing class name in deprecation notice #64

Closed TysonAndre closed 5 years ago

TysonAndre commented 5 years ago

__CLASS__ is only defined inside of a class. The error message was previously The abstract class..., this changes it to The Composer\Semver\Constraint\AbstractConstraint abstract class...

Detected via static analysis.

codecov-io commented 5 years ago

Codecov Report

Merging #64 into master will increase coverage by 1.21%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #64      +/-   ##
============================================
+ Coverage     87.02%   88.23%   +1.21%     
  Complexity      209      209              
============================================
  Files             7        7              
  Lines           447      391      -56     
============================================
- Hits            389      345      -44     
+ Misses           58       46      -12
Impacted Files Coverage Δ Complexity Δ
src/Constraint/AbstractConstraint.php 0% <0%> (ø) 5 <0> (ø) :arrow_down:
src/Constraint/EmptyConstraint.php 40% <0%> (-5.46%) 5% <0%> (ø)
src/Constraint/MultiConstraint.php 73.33% <0%> (-3.81%) 16% <0%> (ø)
src/Constraint/Constraint.php 83.92% <0%> (-0.56%) 28% <0%> (ø)
src/VersionParser.php 95.31% <0%> (+0.48%) 133% <0%> (ø) :arrow_down:
src/Semver.php 97.05% <0%> (+2.32%) 15% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b303e4...36ed5fb. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #64 into master will increase coverage by 1.21%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #64      +/-   ##
============================================
+ Coverage     87.02%   88.23%   +1.21%     
  Complexity      209      209              
============================================
  Files             7        7              
  Lines           447      391      -56     
============================================
- Hits            389      345      -44     
+ Misses           58       46      -12
Impacted Files Coverage Δ Complexity Δ
src/Constraint/AbstractConstraint.php 0% <0%> (ø) 5 <0> (ø) :arrow_down:
src/Constraint/EmptyConstraint.php 40% <0%> (-5.46%) 5% <0%> (ø)
src/Constraint/MultiConstraint.php 73.33% <0%> (-3.81%) 16% <0%> (ø)
src/Constraint/Constraint.php 83.92% <0%> (-0.56%) 28% <0%> (ø)
src/VersionParser.php 95.31% <0%> (+0.48%) 133% <0%> (ø) :arrow_down:
src/Semver.php 97.05% <0%> (+2.32%) 15% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b303e4...36ed5fb. Read the comment docs.

alcohol commented 5 years ago

Sorry, I merged this too quickly. I had to revert it. You may be right, but your solution does not work either because it is supported since php 5.5, and we need to support 5.3 as a minimum still unfortunately :-(

legoktm commented 5 years ago

Hardcoding the class name in the comment without ::class should be equivalent and 5.3 compatible.

alcohol commented 5 years ago

Yep, that would work just fine.

alcohol commented 5 years ago

Could still get the namespace using __NAMESPACE__.