search

composer / semver

Semantic versioning utilities with the addition of version constraints parsing and checking.
MIT License
3.15k stars 76 forks source link

Package phpunit/phpunit-mock-objects is abandoned #66

Closed rodrigoaguilera closed 5 years ago

rodrigoaguilera commented 5 years ago

Composer install is giving me a warning about this package because it depends on an abanadoned library https://packagist.org/packages/phpunit/phpunit-mock-objects

Is there plans to replace it?

stof commented 5 years ago

This should be asked to the maintainers of the package, not to the composer team.

stof commented 5 years ago

In this case, I think the latest version of PHPUnit does not depend on it anymore because the feature was moved back to PHPUnit itself.

alcohol commented 5 years ago

Not sure why we specifically have this extra requirements. Perhaps to enforce a minimum version? Because phpunit also requires it as well. So in theory we should already pull it in when we depend on phpunit alone.

yuceltoluyag commented 5 years ago

Please note that PHPUnit 7 is only supported until February 7, 2020. Also note that PHP 7.1 is no longer actively supported. https://phpunit.de/supported-versions.html

 "require-dev": {
        "phpunit/phpunit": "^7"
    }
alcohol commented 5 years ago

Please note that Semver is part of Composer and we still officially support PHP 5.3 and up.

GrahamCampbell commented 5 years ago

I don't think it matters that the package is abandoned? So is PHP 5, however we want to support that too.

rodrigoaguilera commented 5 years ago

I think this issue should have a couple of followups. A plan to raise the php requirement and then based on the minimum php version required update the phpunit version.

What do you think?

alcohol commented 5 years ago

No need. This will happen eventually when Composer implements new requirements.

DonRichards commented 5 years ago

I'm sorry but I don't follow. phpunit/phpunit is currently being developed but phpunit/phpunit-mock-objects is deprecated and is no longer receiving any updates. phpunit/phpunit-mock-objects is currently being required by this module. @yuceltoluyag are you suggesting this module is also not expected to receive development any further due to the PHPUnit 7 end-of-life in February of 2020?

stof commented 5 years ago

@DonRichards phpunit-mock-objects is not a requirement of this module. It might get installed depending on which phpunit version is selected (due to composer 1.x being compatible with PHP 5.3+, the testsuite may need to use old PHPUnit releases to run tests on old PHP versions).

DonRichards commented 5 years ago

@stof Thanks for clarifying. I didn't see a dependency list in the README, so I relied on Packagist.org's report showing it requires phpunit/phpunit-mock-objects 2.3.0 || ^3.0 But support for PHP5 would kinda make sense. Thanks again. Screen Shot 2019-10-17 at 1 58 31 PM

stof commented 5 years ago

@alcohol it looks like the change you made in April has never been released.

DonRichards commented 5 years ago

@stof 1.5.0 is the latest Tag in this repo. If they rely on tags that's probably the issue.

alcohol commented 5 years ago

I think we haven't tagged a new release because feature wise nothing has changed yet since 1.5. Do you think the new requirements warrant a release/tag?

stof commented 5 years ago

if this was a requirement, it could. Given that this is only a dev requirement, this is fine IMO (as it has no impact on projects using composer/semver).

alcohol commented 5 years ago

Will leave it as-is for now then :+1: