search

composer / semver

Semantic versioning utilities with the addition of version constraints parsing and checking.
MIT License
3.15k stars 76 forks source link

[WIP] Test on PHP 7.4 Stable #74

Closed GrahamCampbell closed 4 years ago

GrahamCampbell commented 4 years ago

Looks like we'll have to upgrade PHPUnit to test on PHP 7.4 properly.

peter279k commented 4 years ago

The Travis CI build is failed on php-7.4 version. The failed message is as follows:

1) Composer\Semver\Constraint\ConstraintTest::testInverseMatchingOtherConstraints
Function ReflectionType::__toString() is deprecated

According to this PHPUnit issue, it seems that the PHPUnit should use 8.2.3 at least for php-7.4 version.

It should define the PHPUnit 8.2.x version on composer.json

GrahamCampbell commented 4 years ago

@peter279k I know, but we can't "just update the version of phpunit". There is some work to do.

peter279k commented 4 years ago

@peter279k I know, but we can't "just update the version of phpunit". There is some work to do.

I know that, and we should concern about new approaches and features for upgrading PHPUnit version :).

GrahamCampbell commented 4 years ago

You're welcome to finish off this PR if you'd like.

GrahamCampbell commented 4 years ago

If someone wants to take over here, and finish this, that would be good. I don't have the free time needed to finish this at the moment.