composewell / streamly

High performance, concurrent functional programming abstractions
https://streamly.composewell.com
Other
864 stars 66 forks source link

Reconcile parser APIs accepting folds/parsers #1601

Open harendra-kumar opened 2 years ago

harendra-kumar commented 2 years ago

For example we have a takeWhile and takeWhileP. Should we keep both or just rename takeWhileP as takeWhile because it is more powerful and covers the other case as well.

harendra-kumar commented 2 years ago

There are other such parsers if we plan to keep both versions than we need to follow the naming convention so that we rename the Parser accepting ones with a P suffix, specifically takeEndBy parser.