search

composewell / streamly

High performance, concurrent functional programming abstractions
https://streamly.composewell.com
Other
859 stars 64 forks source link

Rename MutArray APIs to follow naming conventions #2784

Open harendra-kumar opened 2 months ago

harendra-kumar commented 2 months ago 
castUnsafe => unsafeCast
newArrayWith => emptyWithAligned
getSliceUnsafe => unsafeGetSlice
createOfWith => createWithOf (argument order convention)
putIndexUnsafe => unsafePutIndex
modifyIndexUnsafe => unsafeModifyIndex
getIndexUnsafe => unsafeGetIndex
realloc => reallocBytes
reallocWith => reallocBytesWith
snocUnsafe => unsafeSnoc
spliceUnsafe => unsafeSplice
pokeAppend   => poke
pokeAppendMay  => pokeMay
pokeSkipUnsafe => unsafePokeSkip
peekUncons   => peek
peekUnconsUnsafe => unsafePeek
peekSkipUnsafe  => unsafePeekSkip

pinnedWriteNAligned is listed under deprecated but not marked DEPRECATED.

adithyaov commented 2 months ago

Suggestions:

pokeAppend => snocBytes, snocAsBytes
pokeAppendMay => snocBytesMay, snocAsBytesMay
adithyaov commented 1 week ago

This is already done in https://github.com/composewell/streamly/pull/2792