composewell / streamly

High performance, concurrent functional programming abstractions
https://streamly.composewell.com
Other
861 stars 66 forks source link

Streamly doesn't build with Stack on Mac OS #2836

Closed AliceRixte closed 1 week ago

AliceRixte commented 1 week ago

Added CI in order to investigate stack build failing on Mac OS. See issue #2833.

harendra-kumar commented 1 week ago

You can do the following:

harendra-kumar commented 1 week ago

The stack CIs are not able to start because of config issue in the yaml file:


Haskell CI
Error when evaluating 'continue-on-error' for job 'build'. .github/workflows/haskell.yml (Line: 65, Col: 24): Unexpected value ''

You can remove the continue-on-error section, the name section, fail-fast and ignore_error in all CIs:

    continue-on-error: ${{ matrix.ignore_error }}
      fail-fast: true
        name:
          - 9.10.1-Werror

            ignore_error: false
harendra-kumar commented 1 week ago

In stack.yaml here, comment out the extra deps. You can also comment out test and benchmark under packages section.

I have changed the settings of the repo so it should not require explicit approval to run CIs on your PR.

AliceRixte commented 1 week ago

Nice, we got it ! The fail on GHC 9.8.2-stack-nightly-september is the error I have. So apparently it is a fairly recent break, as the latest stack LTS works properly.

Tell me if you need more help now that we reproduced the fail.

harendra-kumar commented 1 week ago

@AliceRixte I added a CI with latest stack nightly and used a verbose option as well to see if it gives any info. Can you raise an issue on the stack repo mentioning the output of this CI: https://github.com/composewell/streamly/actions/runs/11062893476/job/30738127480?pr=2842 . I am merging that PR #2842 to keep this CI. We will continue monitoring until this passes.

AliceRixte commented 1 week ago

@harendra-kumar That's great ! Thank you so much !