composewell / unicode-data

Access unicode character database
Apache License 2.0
18 stars 6 forks source link

Upload unicode-data-0.3 to hackage #55

Closed harendra-kumar closed 2 years ago

harendra-kumar commented 2 years ago

Thanks to @wismill we have significant functionality committed to the package. We can now upload the new release candidate to hackage.

@wismill what is your hackage id, I will add you to package maintainers so that you can upload it.

We can use this issue as a checklist to do any remaining due diligence required for the release.

wismill commented 2 years ago

My hackage ID is wismill.

harendra-kumar commented 2 years ago

@adithyaov can you review if the package is ready for release or if there is anything that should be done. I don't think the bench-show based comparison should be a blocker, we can do that later. Mainly, testing, performance, breaking changes, docs, dependencies should be reviewed.

adithyaov commented 2 years ago

I went through the release checklist.

TBD:

harendra-kumar commented 2 years ago

It would be better to not use --publish right away so that we can check the candidate before publishing.

wismill commented 2 years ago

See: https://hackage.haskell.org/package/unicode-data-0.3.0/candidate

harendra-kumar commented 2 years ago

First time after a long time, I saw haddock being generated for a candidate.

https://hackage.haskell.org/package/unicode-data-0.3.0/candidate/docs/Unicode-Char.html - How come case conversion ops are not in the Unicode.Char.Case module?

wismill commented 2 years ago

First time after a long time, I saw haddock being generated for a candidate.

I have uploaded it manually.

https://hackage.haskell.org/package/unicode-data-0.3.0/candidate/docs/Unicode-Char.html - How come case conversion ops are not in the Unicode.Char.Case module?

It seems so by design.

harendra-kumar commented 2 years ago

Ah, that's because of hiding. Ok, then. Looks good to me.

I have uploaded it manually.

huh...I was happy that it's fixed, but it's not.

wismill commented 2 years ago

Is there anything else to do before the release?

harendra-kumar commented 2 years ago

Go ahead and publish it.

harendra-kumar commented 2 years ago

Also, if you feel like making an announcement on haskell discourse/reddit or any other forums please do that too. Significant changes have gone in this package, it should be quite useful now, so it may be a good idea to let others know about it.

wismill commented 2 years ago

Release done.

Also, if you feel like making an announcement on haskell discourse/reddit or any other forums please do that too. Significant changes have gone in this package, it should be quite useful now, so it may be a good idea to let others know about it.

Good idea. I will do it soon.

wismill commented 2 years ago

Announcement:

harendra-kumar commented 2 years ago

Strangely, reddit removed the post, it says: Reddit's automated bots frequently filter posts it thinks might be spam.

wismill commented 2 years ago

I already contacted the moderators but got no response

harendra-kumar commented 2 years ago

I think it may be likely to be classified as spam if there is only a link and no description.

wismill commented 2 years ago

New attempt: Reddit