search

composewell / unicode-transforms

Fast Unicode normalization in Haskell
BSD 3-Clause "New" or "Revised" License
47 stars 16 forks source link

Do not import Data.Text.Internal.Unsafe.Shift #63

Closed Bodigrim closed 3 years ago

Bodigrim commented 3 years ago

Data.Text.Internal.Unsafe.Shift has been removed in https://github.com/haskell/text/commit/a1f974cd517f548c5b658d1605cb9498fbcff95e

harendra-kumar commented 3 years ago

We will have to make a minor release before text is released.

Is text going to bump major version with this change? Otherwise unicode-transforms' version bounds will allow new text version, breaking it. We should try to reduce other internal imports from text as well? We can just possibly copy the simple ones. We should depend on the minor version of text here:

    , text >=1.1.1 && <1.3

Need to fix the CIs, travis ones are to be migrated to github.

Bodigrim commented 3 years ago

We will have to make a minor release before text is released.

No urgency with a release, there are more changes to text to accomodate, scheduled for upcoming months.

Is text going to bump major version with this change?

Yes, indeed.