Fix for #497 (ORA-00920: invalid relational operator with CPK 12.0.0)

composite-primary-keys / composite_primary_keys

Composite Primary Keys support for Active Record

1.03k stars 350 forks source link

Fix for #497 (ORA-00920: invalid relational operator with CPK 12.0.0) #499

Closed awaltman closed 4 years ago

awaltman commented 5 years ago

The name of the subquery alias on Oracle cannot start with the underscore character. See: https://docs.oracle.com/en/database/oracle/oracle-database/12.2/sqlrf/Database-Object-Names-and-Qualifiers.html#GUID-75337742-67FD-4EC0-985F-741C93D918DA

This change also fixes an issue when deleting all records if the association contains an order option.

cfis commented 4 years ago

Just following up, where do we stand on this?

awaltman commented 4 years ago

I'm going to go ahead and close this pull request and will create another request which includes just the fix for the alias name when I have more time. I apologize for the delay.

cfis commented 4 years ago

No worries, thanks.