Active record 5.2.4 compatability

composite-primary-keys / composite_primary_keys

Composite Primary Keys support for Active Record

1.03k stars 350 forks source link

Closed eanders closed 4 years ago

eanders commented 4 years ago

This is based on https://github.com/composite-primary-keys/composite_primary_keys/pull/512. Working to get the tests for MySQL and SQL Lite passing.

From #512: In rails/rails@54de9b1 (v5.2.4) ActiveRecord::Reflection::AbstractReflection#build_join_constraint method was removed.

Fixes incorrect SQL condition for joining by CPK.

cfis commented 4 years ago

Since #512 is applied I assume this is no longer necessary?

As for the schema updates, make those a separate pull request. That would make it easier to apply to master branch too.

Thanks - Charlie