search

composite-primary-keys / composite_primary_keys

Composite Primary Keys support for Active Record
1.03k stars 350 forks source link

Switch CI from Travis CI to GitHub Actions #540

Closed ta1kt0me closed 3 years ago

ta1kt0me commented 3 years ago

When merging a library update such as renovate into our product, I wanted to make sure that the CI of the library passed, so I worked on #537 . Currently, Travis CI results on this project continue to fail, so I want to improve the situation where it is difficult to confirm that library changes are safe.

Since I think that using multiple different DBs at the same time in Rails application is not a realistic use case, so it defines a workflow for each DB.

cfis commented 3 years ago

This looks awesome. So once this is merged, what would be the next steps? Does it just work with Github actions or do we need to go setup something with Github?

ta1kt0me commented 3 years ago

I think it enables GitHub Actions in the origin repository as well after merge. And it's good to limit permissions. Could you try below steps?

  1. Go to Settings > Actions
  2. Check Allow select actions, then select both Allow actions created by GitHub and Allow Marketplace actions by verified creators inActions permissions section
cfis commented 3 years ago

Awesome. Merged and actions updated as you specified. Actions are now running!