search

composite-primary-keys / composite_primary_keys

Composite Primary Keys support for Active Record
1.03k stars 350 forks source link

cpk fails when used with rspec stub_model in rails 6.0 #581

Closed toddwf closed 1 year ago

toddwf commented 2 years ago

There seems to be a longstanding issue with using cpk with rspec-mocks. I only have a partial solution to the problem. I'll post code after the weekend but I wanted to ask whether anyone's had problems with rspec stub_model (rspec 3.11.0 rspec-mocks 3.11.1) and since it is involving rspec (specifcally rspec-mocks) how it should be handled. It would ultimately be a patch to the rspec code.

Thank you!

cfis commented 2 years ago

I've only ever used minitest with CPK so not sure. Good luck and happy to take a patch if you develop one.

cfis commented 1 year ago

Going to close since there hasn't been any followup.

toddwf commented 1 year ago

This is still an issue. I had to create a monkeypatch to get around it and that has broken my tests due to the namespacing of the patch. I looked through tests in the repo and didn't see one that looked like an explicit test on this issue. I started the process to submit but the test env overhead is significant and I was pulled in other directions. If there's a pre-built VM LMK, otherwise I'll get back to it when I can. But this is very much an issue for me. What do you do if no one else reports/confirms? Leave it closed unless I can get the test env up and submit a patch or?

cfis commented 1 year ago

Hi @toddwf - happy to reopen. If you have a test case to reproduce that would be really helpful.

toddwf commented 1 year ago

I'm going to close this. My previous comment conflated it with another issue. If I am able to revisit it, I'll reopen it and submit a test case.

cfis commented 1 year ago

Sounds good - thanks.