search

composite-primary-keys / composite_primary_keys

Composite Primary Keys support for Active Record
1.03k stars 350 forks source link

AR 5.2: Support polymorphic_name #603

Closed marshall-lee closed 1 year ago

marshall-lee commented 1 year ago

polymorphic_name was introduced in 5.2.0 but wasn't properly ported to CPK.

marshall-lee commented 1 year ago

@cfis Hi and thanks for merging of #604 #605 and #606 to support polymorphic_name in Rails >= 6! But one of my codebases is still on 5.2 and this fix is actually crucial there. I humbly ask you please merge the fix into upstream so I can refer to the official repo in my Gemfile. I know 5.2 is EOL many years ago but things are not that smooth sometimes, sometimes codebases are stuck with older versions.

cfis commented 1 year ago

Yes sure, thought I had merged it. Done now.

Thanks for the fixes!

marshall-lee commented 11 months ago

@cfis Hi! Is there a chance 11.x, 12.x and 13.x versions with this fix be released on rubygems?

cfis commented 11 months ago

Well I would usually only do 14.x and 13.x - anything older is unsupported. Do you really need it on all those releases?

marshall-lee commented 11 months ago

@cfis i'm in the process of upgrading to 6.1 so 13.x would be fine!

cfis commented 11 months ago

Coo, done.