Closed cylon56 closed 2 years ago
There are some good points made about the chosen names, however naming is a notoriously hard problem and we believe it is difficult if not impossible to make everyone happy. We adopted some of the proposed changes in #433.
To favor explicitness and readability, several parts of the contracts may benefit from better naming. Here are some examples:
CometProxyAdmin
suggests that it is only the admin of the Comet proxy, but in reality, it will also have the same role on theConfigurator
proxy. Choose another name to avoid confusion.TransparentUpgradeableConfiguratorProxy
can be calledConfiguratorProxy
. There is no need to use the inherited contract name as a prefix.CometMath
, changeInvalidUInt
toInvalidUint
andtoUInt
totoUint
.rescale
anddescale
have different names but the same value, consider using one variable namescale
.