Update code in repository and website to latest deployed code

[fulldecent]

Issue & work plan

As per the 2018-12-09 blog post and 2018-12-15 update, new contracts were deployed to the blockchain and are used in production:

• An updated rate model, 0xcdaf8cb1839952cbe6d98d248e593b782a2419c7 and stablecoin rate model, 0x8ac03df808efae9397a9d95888230ee022b997f4
• An updated price oracle, 0x9e77ad51e5c0825d6e440f49e49ef1a1bca37b5d
• A liquidation contract, 0x1055be4bf7338c7606d9efdcf80593f180ba043e— To participate in the liquidation process, you must first ERC-20 approve the liquidation contract to use your token balances, and submit transactions through the contract

This is the latest blog post so I understand this information to be current.

Several sources of information in Compound Finance repositories and websites now contain outdated information:

• [ ] https://compound.finance/developers -- incorrect deployment addresses for PriceOracle (sort of) and InterestRateModel

  Contract	ABI	Address
  MoneyMarket	JSON	0x3fda67f7583380e67ef93072294a7fac882fd7e7
  PriceOracle	JSON	0x02557a5e05defeffd4cae6d83ea3d173b272c904
  InterestRateModel	JSON	0xd25c029a607ee888bdbdbe054515e25ec6f3fff9

  • [ ] Technically, this is not an "An updated price oracle", it is a proxy
• [ ] https://compound.finance/developers -- incorrect JSON ABIs
• [ ] https://compound.finance/developers -- incorrect contract name (InterestRateModel => LCInterestRateModel), and this should be specified as the "Standard" interest rate model to avoid confusion with upcoming Stable Coin interest rate model
• [ ] https://compound.finance/developers -- (possibly) incorrect function documentation
• [ ] https://github.com/compound-finance/compound-money-market/ -- outdated code
• [ ] https://github.com/compound-finance/compound-oracle -- outdated code
  • A change (some simple logging and a level of proxy indirection) was also added to the price oracle, however this was not disclosed on the blog entry above
• [ ] https://github.com/compound-finance/compound-oracle/releases -- outdated deployment address
• [ ] https://github.com/compound-finance/compound-money-market/releases -- lack of deployment address (please follow the example at https://github.com/compound-finance/compound-oracle/releases or https://github.com/su-squares/ethereum-contract/releases)
• [ ] https://medium.com/compound-finance/compound-launches-money-markets-for-ethereum-assets-f50920f04488 -- includes old deployment address, recommend to add a comment inline there

Impact

Inaccurate information will continue to propagate. Somebody may find the old deployment addresses or ABI listed on the the Compound Finance website and build something around it, it might cause something to break.

Also, not having a place to read the preferred editable (i.e. not compiled) contract source code makes analysis more difficult. Lack of analysis leads to unrecognized bugs.

Discussion

Nobody likes re-deploying code they previously thought was final. But may I recommend as insurance against similar issues as this occurring on future re-deployments (if any), a new DEPLOY.md file be added to this repository. The scope of this file would be to explain the exact process for re-deploying any code. You may use https://github.com/su-squares/ethereum-contract/blob/master/DEPLOY.md as a starting point.

Of course during re-deployment the first thought is always "prevent customer loss of funds" and "call the lawyers", but it does help to have that DEPLOY.md file staring you in the face rather than waiting a month later and somebody remembers "hey, we should go look up that issue @fulldecent opened last time this happened."

[fulldecent]

Closing. It seems this repo is unmaintained.