compserv / hkn-rails

The website for HKN Mu Chapter
https://hkn.eecs.berkeley.edu
Other
5 stars 10 forks source link

Course surveys for TAs starting Fall 2022 onwards have wrong maximum score #313

Open lo-maxwell opened 1 year ago

lo-maxwell commented 1 year ago

In F22 the department started using survey questions that have a maximum score of 7, but we are still mapping them to questions that have a maximum of 5 (https://github.com/compserv/hkn-rails/blob/master/app/helpers/admin/csec_admin_helper.rb#L7). Because this is done at survey upload time, the data is already all converted over. It is relatively simple to create a new survey question (with a max of 7) and replace all existing f22 surveyquestions of that type with the new one, but we should also look into if mapping questions is even necessary at this point, with the new code changes to allow multiple types of effectiveness/worthwhile questions. See https://hkn.eecs.berkeley.edu/coursesurveys/course/CS/61C/2022_Fall for an example of all the questions being out of 7 points instead.