Closed hmaurer closed 9 years ago
Nice one.
So does this integrate within the existing site, or fills the entire screen kind of thing?
At the moment it's just a 100% height & width iframe. It would be nice to add a header but I think you need some javascript to make the iframe fill the rest of the page (or css3 flexbox / using a table?) => @AngusP
Don't we have a Raw HTML mode for making pages? If so, why not just embed via that?
Just use markdown for everything as you can put raw HTML in there and it'll be fine
We could but then it won't fill the entire page.
On 3 April 2014 12:42, Angus Pearson notifications@github.com wrote:
Just use markdown for everything as you can put raw HTML in there and it'll be fine
Reply to this email directly or view it on GitHubhttps://github.com/compsoc-edinburgh/website-django/issues/25#issuecomment-39441343 .
elaborating on my quick reply:
@Emberwalker we could; but it is convenient to have the IRC client in full page, or at least full width. At the moment any CMS-based page has a sidebar, which leaves a very narrow container for the IRC client. We could add a show_sidebar
boolean option on each page so that it can be disabled when convenient. I still think that the IRC client would be better full page though, with only a small header on top with the logo and a link back to the website.
I could see a show_sidebar
variable being useful.
@Emberwalker yep I think so too, even outside the context of this issue it's sometimes useful to make the content full-width. We should refactor the whole navigation system anyway; how's that coming along (tree-based thingy)?
I'm not sure - I'll open a seperate issue for show_sidebar
What's up with this? The web-based IRC client is accessible at https://comp-soc.com/compsoc/irc; should we add a link somewhere on the website?
Since when did that work?! :D. Probably will have to be hard coded into the navbar
On Tue, Aug 26, 2014 at 11:33 PM, a3gis notifications@github.com wrote:
What's up with this? The web-based IRC client is accessible at https://comp-soc.com/compsoc/irc; should we add a link somewhere on the website?
Reply to this email directly or view it on GitHub: https://github.com/compsoc-edinburgh/website-django/issues/25#issuecomment-53503219
It's now accessible as of 3814dcd
Perfect; re-open if something comes up on the topic.
https://github.com/compsoc-edinburgh/website-django/commit/7799abd5746b7512b6872f32c3bfae7198826851
TODO: