search

compucorp / civibooking

CiviBooking is a CiviCRM extension defining a resource booking application that runs on top of the CiviCRM platform.
Other
19 stars 44 forks source link

Remove reference to protected $_id because it is already declared in Base Parent Class #199

Open awasson opened 1 year ago

awasson commented 1 year ago

The CiviCRM Base class, "CRM_Admin_Form extends CRM_Core_Form" declares a public $_id variable and redeclaring it as protected causes a fatal error. This pull request removes protected $_id from 6 forms although the reference to protected $_id was already commented out in CRM/Booking/Form/SelectResource.php

colemanw commented 1 year ago

Looks like this has been fixed in the maintained version of this extension: https://lab.civicrm.org/extensions/booking/-/commit/31d9bcd4580f6f03e61bfdf900b6d1b313651f8f