compucorp / uk.co.compucorp.civicrm.pivotreport

CiviCRM Pivot table reporting solution
Other
8 stars 13 forks source link

CPS-342: Remove is_current_revision parameter from count api #121

Closed shahrukh-compucorp closed 3 years ago

shahrukh-compucorp commented 3 years ago

Overview

This pr removes the is_current_revision parameter from the contribution count api call to remove the discrepancies between count api and data api calls for contribution.While sending the api call for fetching the contribution count we are attaching an extra parameter by the name of is_current_revision as can be seen here but while fetching the actual data the same parameter was not being sent as can be seen here This led to different data in both the apis.

Before

The count of data was not getting effected even after new records were being inserted.

After

Removal of the extra is_current_revison results in correct count being fetched through the api.