compucorp / uk.co.compucorp.civicrm.pivotreport

CiviCRM Pivot table reporting solution
Other
8 stars 13 forks source link

COMCL-101: Regenerate civix file and Base upgrader class #124

Closed erawat closed 3 years ago

erawat commented 3 years ago

Overview

This PR fixes is to updates civix file and an upgrader base class. The base class and civix file are generated automatically by running civix generate:upgrader The reason for regenerating the civix file and base upgrader class because CiviCRM changed the way they handle warning for using a deprecated function. See this PR .

The changed will always throw use deprecated warning if the deprecated function is used in anywhere, for example, Drupal module, CiviCRM extension. This would not have an issue we install the extension / module via user interface. However, when we use Drush site-install command to install the Drupal site that ship with a Drupal profile that install the extension when creating a site.

Any module or extension that use CiviCRM's deprecated function in the installation hook, upgrade hook, the E_USER_DEPRECATED warning will throw during installation, but Drush handles deprecated messages as an error rather than a warning.

Since the old civix file and Base class are using the deprecated functions, we will also receive the error duration installation, for this reason, the deployment will always fail. This PR fixes this.

Note

PR for fixing this issue in Drush has been created and merged to Druah 8.x https://github.com/drush-ops/drush/pull/4565, but we do not have a timescale for new Drush version to release, thus we fixed the extension.

erawat commented 3 years ago

Merged as passed testing on COMCL-102