This PR solved the error presented on Activity reports, which made the page keep loading indefinitely.
Before
On Reports > Pivot Report > Activity, the progress bar keep loading without end, with numbers greater than the 100%
After
The page finishes loading correctly.
Technical Details
The fix consists of not overriding the $page variable that is being passed on the getPaginatedResults method. This variable keeps track of the last page used for a giving index, when called in rebuildData method, on the same class.
It should be reset to 0 only when the index change.
Overview
This PR solved the error presented on Activity reports, which made the page keep loading indefinitely.
Before
On Reports > Pivot Report > Activity, the progress bar keep loading without end, with numbers greater than the 100%
After
The page finishes loading correctly.
Technical Details
The fix consists of not overriding the
$pagevariable that is being passed on thegetPaginatedResultsmethod. This variable keeps track of the last page used for a giving index, when called inrebuildDatamethod, on the same class. It should be reset to 0 only when the index change.