This PR is to remove Membership type APIs that were created for getting details membership types detail that used for calculating prorata and updating instalment.
These codes are not currently used on the current version of membership extras and will not be used for the new UI on Membership Extra version 5.
## Before
Below APIs were used on PaymentPlanToggler form but the code was commented out- Getinstalmentamounts- Getinstalmentamountsforpriceset
if (instalmentFrequency == 1 && instalmentFrequencyUnit == 'month') {
//Commented out for now till the BE functionality to store these values are in place.
// updateInstalmentAmounts();
}
- APIs will be deleted as they are no longer in used.
~~- MembershipAmountProRata hook is also deleted as they will not be used. ~~
## Technical Details
Why delete this API instead of re-using them for the new UI? This UI is actually returning values of membership type and the calculation is done on the front end which is currently incorrect.
One of the requirements for the UI changes is to calculate the schedule / instalment on the backend and only use the front end to display the instalment. In order to achieve this, the new set of APIs will be created.
This PR was merged incorrectly to work stream branch. New PR will be created, work stream branch has been restored to the state before this PR is merged.
Overview
THIS PR HAS NOT BEEN MERGED AS THE WORKSTREAM BRANCH WAS RE-STORED TO THE COMMITS BEFORE THIS PR IS MERGED. NEW PR IS CREATED. https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/298
This PR is to remove Membership type APIs that were created for getting details membership types detail that used for calculating prorata and updating instalment.These codes are not currently used on the current version of membership extras and will not be used for the new UI on Membership Extra version 5.## BeforeBelow APIs were used on PaymentPlanToggler form but the code was commented out- Getinstalmentamounts- Getinstalmentamountsforpricesethttps://github.com/compucorp/uk.co.compucorp.membershipextras/blob/master/templates/CRM/Member/Form/PaymentPlanToggler.tpl#L117Below APIs were used in prorata form hook.- Getproratedamountforpriceset.php~~- Getdatesformembershiptype.php ~~- Getproratedamount.php~~## After ~~
- APIs will be deleted as they are no longer in used.~~- MembershipAmountProRata hook is also deleted as they will not be used. ~~## Technical DetailsWhy delete this API instead of re-using them for the new UI? This UI is actually returning values of membership type and the calculation is done on the front end which is currently incorrect.One of the requirements for the UI changes is to calculate the schedule / instalment on the backend and only use the front end to display the instalment. In order to achieve this, the new set of APIs will be created.