compucorp / uk.co.compucorp.membershipextras

Membership Extras for CiviCRM
Other
5 stars 8 forks source link

IO-105: Fix Upgrade rules UI issues #307

Closed omarabuhussein closed 3 years ago

omarabuhussein commented 3 years ago

Overview

Fixing some UI issues related to upgrade rules functionality.

Before

1- When trying to delete an upgrade rule, the following confirmation message appears :

Are you sure you want to delete this membership automated upgrade rule?

but it should be :

Are you sure you would like to delete the automated upgrade rule?

2- Clicking on Cancel button on create/update/delete forms returns to CiviCRM dashboard screen instead of the rules management screen.

3- Putting a value > 3 in the "Held For" field will result in not showing the period unit but only its length.

2020-10-30 01_10_59-Window

After

1-

2020-10-30 01_08_40-Window

2-

3333333333

3-

2020-10-30 01_12_18-Window