compucorp / uk.co.compucorp.membershipextras

Membership Extras for CiviCRM
Other
5 stars 8 forks source link

BASW-289: Avoid Saving End Date for Lifetime Memberships #310

Closed MiyaNoctem closed 3 years ago

MiyaNoctem commented 3 years ago

Overview

On our instalment management screen, we are able to specify start date and end date when adding a membership line. The start date and end date will control two things:

narrowing down the instalments that the new membership line should apply to setting the start date and end date of the membership We want to avoid setting the end date of life memberships but also not taking away the ability to perform point 1 and 2 for other memberships.

This was previously addressed in this PR https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/192 , but got reverted prior to a release.

Before

Every membership added via the View/Modify Future Installments screen had an end date set when creating/updating.

image

After

End date is only set for memberships that are not lifetime.

image