MAE-400: Fix Receive Date on Fixed Single Instalment Renewal

[MiyaNoctem]

Overview

If you create a new fixed membership to a contact with Auto-renew set, payment plan 1 installment and with the following dates:

• Member Since - 1 July 2019
• Member Start - 1 July 2019
• Member End Date - 30/11/2019 (Auto-filled)
• Payment Received Date - 1 July 2019

After renewing, the dates will get updated to:

• Member Since - 1 July 2019 - Correct
• Member Start - 1 July 2019 - Correct
• Member End Date - 30/11/2020 - Correct
• New Contribution Date - 1 July 2019 - Incorrect

New contribution date should be 1 Dec 2019

Before

When renewing a payment plan with a single installment, the new recieve date is calculated from the initial cycle day of the payment plan, which was the 1st of july (day 182 of the year). Thus, all contribution recieve dates are calculated to be on that day of the corresponding year.

After

Fixed by setting the contribution's receive date as the memberships' calculated start date if there is at least one fixed membership in the payment plan. For the evaluated scenario, this would mean the recieve date of the new contribution would be 1st of Dec, 2019.

Notes

Added a test to verify the scenario.

This work started in PR #314 , but decided to re-do on top of latest master branch, as the original branch had gone stale.

[erawat]

@MiyaNoctem the files name and actual class name still Installment. Can you help to fix this too? Since you are chaining it, and if you could change the actual class name to CRM_MembershipExtras_Job_OfflineAutoRenewal_SingleInstalmentPlan? cc @omarabuhussein