compucorp / uk.co.compucorp.membershipextras

Membership Extras for CiviCRM
Other
5 stars 8 forks source link

COMCL-101: Use postInstall hook for settings membership extras #351

Closed erawat closed 3 years ago

erawat commented 3 years ago

Overview

This PR is to change the hook on installation from install hook to post install hook.

The reason for changing is that the tasks for creating default values that created during installation for example membership extras settings and other values may not be available yet for subsequence steps like set default value into the one of the settings. Therefore, the subsequences steps that require settings should be done in the post install hook which is immediately called after installed is done.

Before



## After

- postInstall hook is used. 
- No error threw during is installation. 
ahed-compucorp commented 3 years ago

Confirmed that method "postInstall" is called and ran successfully without any errors reported in the log file.