MAE-507: Handle applying discount code when no membership is selected - Githubissues

compucorp / uk.co.compucorp.membershipextras

Membership Extras for CiviCRM

Other

5 stars 8 forks source link

MAE-507: Handle applying discount code when no membership is selected #370

Closed ahed-compucorp closed 3 years ago

ahed-compucorp commented 3 years ago

Overview

This PR address JavaScript error appeared after applying discount code when no membership is selected.

Before

Peek 2021-03-25 17-49

After

Peek 2021-03-25 17-50

Technical Details

Uncaught TypeError: Cannot read property 'financial_type_id' of undefined

This JavaScript error prevented the execution of the remaining code especially initializing the date-picker.

Also updated the workflows file to CiviCRM 3.35.1 .After that, I have to fix the broken tests because of :

Leap year issue - see this commit.
CRM_Core_Form::add method throws a deprecated warning if the 4th parameter wasn't an array.