compucorp / uk.co.compucorp.membershipextras

Membership Extras for CiviCRM
Other
5 stars 8 forks source link

MAE-551: Make membership manual renewal screen work with version 5 UI #386

Closed erawat closed 3 years ago

erawat commented 3 years ago

Overview

This PR fixes the issue when using renewal membership manually.

Before

When clicking Renew from the form, the indicator kept spinning due to the error happens in the backend.

MAE-551

After

Peek 2021-08-04 13-50

Technical Details

The MembershipPaymentPlanProcessor and paymentPlanToggler.js designed to use start_date field to pass to the API to generate instalments as well as using as the first contribution received date. The start_date` field only exists in the new membership form and does not exist in the renewal membership form.

This PR updates MembershipPaymentPlanProcessor and paymentPlanToggler.js to use renewal_date as contribution received date when using renewal membership form.