search

compucorp / uk.co.compucorp.membershipextras

Membership Extras for CiviCRM
Other
5 stars 8 forks source link

PROD-33: Add civicrm_contribution_recur to LineItem supported entity options #404

Closed olayiwola-compucorp closed 2 years ago

olayiwola-compucorp commented 2 years ago

Overview

CiviCRM decided to limit the supported entity_table options to some predefined tables as seen in this PR https://github.com/civicrm/civicrm-core/pull/20464, this is now causing error in this extension, because this extension allow users to add LineItems to civicrm_contribution_recur table which is not part of the predefined tables.

Before

343d1bc5-732a-4a6c-bdd7-fb3cee8f9b01

After

after-line-item

Technical Details

implement the hook_civicrm_fieldOptions hook to add civicrm_contribution_recur to the LineItem options.

omarabuhussein commented 2 years ago

@olayiwola-compucorp ah interesting, so we don't need this anymore https://github.com/compucorp/civicrm-core/pull/78 or even a PR to the core right ?

olayiwola-compucorp commented 2 years ago

@olayiwola-compucorp ah interesting, so we don't need this anymore compucorp/civicrm-core#78 or even a PR to the core right ?

Yes, we don't need that anymore

omarabuhussein commented 2 years ago

Given that this passed testing already, and that we will need it for V5, I rebased it with the current master branch (which includes V5 now) and will merge it.