compucorp / uk.co.compucorp.membershipextras

Membership Extras for CiviCRM
Other
5 stars 8 forks source link

MAE-634: Remove obsolete code from BASW-175 work #415

Closed omarabuhussein closed 2 years ago

omarabuhussein commented 2 years ago

Overview

BASW-175 that allowed users to be able to adjust Payment plans total amount manually, but on Membership V5 we simplified many things and one of these simplification was to prevent users from manually altering the payment plan amount (and instead they can use price sets/fields to give memberships to members using non default prices). This commit: https://github.com/compucorp/uk.co.compucorp.membershipextras/commit/62f342ef4de69e5a959ce1b05ea722788d6c48ea removes the code that was responsible for recalculating the tax amount and line items amounts if the user change the amount manually since it is no longer relevant. so in this PR I am removing it.