COMCL-169: Update CiviCRM version in tests workflow

[omarabuhussein]

Overview

• Updating CiviCRM version in tests workflow to match the CiviCRM version on Compuclient 1.29
• After the update, this class tests CRM_MembershipExtras_Hook_Pre_MembershipPaymentPlanProcessor_LineItemTest started to fail:

  
  1) CRM_MembershipExtras_Hook_Pre_MembershipPaymentPlanProcessor_LineItemTest::testProRatedPriceSetContributionLineItemOnCalculationByMonthFixedMembershipType
  CiviCRM_API3_Exception: passing in incorrect tax amounts is deprecated

/w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/api/api.php:134 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/CRM/MembershipExtras/Test/Fabricator/Base.php:37 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/CRM/MembershipExtras/Test/Fabricator/Contribution.php:25 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/tests/phpunit/CRM/MembershipExtras/Hook/Pre/MembershipPaymentPlanProcessor/LineItemTest.php:274 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/tests/phpunit/CRM/MembershipExtras/Hook/Pre/MembershipPaymentPlanProcessor/LineItemTest.php:159 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/tests/phpunit/CRM/MembershipExtras/Hook/Pre/MembershipPaymentPlanProcessor/LineItemTest.php:44 /buildkit/civicrm-buildkit/extern/phpunit5/phpunit5.phar:598

2) CRM_MembershipExtras_Hook_Pre_MembershipPaymentPlanProcessor_LineItemTest::testProRatedPriceSetContributionLineItemOnCalculationByDaysFixedMembershipType CiviCRM_API3_Exception: passing in incorrect tax amounts is deprecated

/w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/api/api.php:134 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/CRM/MembershipExtras/Test/Fabricator/Base.php:37 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/CRM/MembershipExtras/Test/Fabricator/Contribution.php:25 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/tests/phpunit/CRM/MembershipExtras/Hook/Pre/MembershipPaymentPlanProcessor/LineItemTest.php:274 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/tests/phpunit/CRM/MembershipExtras/Hook/Pre/MembershipPaymentPlanProcessor/LineItemTest.php:159 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/tests/phpunit/CRM/MembershipExtras/Hook/Pre/MembershipPaymentPlanProcessor/LineItemTest.php:72 /buildkit/civicrm-buildkit/extern/phpunit5/phpunit5.phar:598

3) CRM_MembershipExtras_Hook_Pre_MembershipPaymentPlanProcessor_LineItemTest::testAlterNonPriceSetLineItemForFixedMembershipType CiviCRM_API3_Exception: passing in incorrect tax amounts is deprecated

/w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/api/api.php:134 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/CRM/MembershipExtras/Test/Fabricator/Base.php:37 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/CRM/MembershipExtras/Test/Fabricator/Contribution.php:25 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/tests/phpunit/CRM/MembershipExtras/Hook/Pre/MembershipPaymentPlanProcessor/LineItemTest.php:274 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/tests/phpunit/CRM/MembershipExtras/Hook/Pre/MembershipPaymentPlanProcessor/LineItemTest.php:159 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/tests/phpunit/CRM/MembershipExtras/Hook/Pre/MembershipPaymentPlanProcessor/LineItemTest.php:96 /buildkit/civicrm-buildkit/extern/phpunit5/phpunit5.phar:598

4) CRM_MembershipExtras_Hook_Pre_MembershipPaymentPlanProcessor_LineItemTest::testAlterLineItemForRollingMembershipType CiviCRM_API3_Exception: passing in incorrect tax amounts is deprecated

/w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/api/api.php:134 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/CRM/MembershipExtras/Test/Fabricator/Base.php:37 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/CRM/MembershipExtras/Test/Fabricator/Contribution.php:25 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/tests/phpunit/CRM/MembershipExtras/Hook/Pre/MembershipPaymentPlanProcessor/LineItemTest.php:274 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/tests/phpunit/CRM/MembershipExtras/Hook/Pre/MembershipPaymentPlanProcessor/LineItemTest.php:159 /w/uk.co.compucorp.membershipextras/uk.co.compucorp.membershipextras/site/web/sites/all/modules/civicrm/tools/extensions/uk.co.compucorp.membershipextras/tests/phpunit/CRM/MembershipExtras/Hook/Pre/MembershipPaymentPlanProcessor/LineItemTest.php:132 /buildkit/civicrm-buildkit/extern/phpunit5/phpunit5.phar:598

Which is due to a change in CiviCRM BAO class that expects: 

- If `skipLineItem` param is set to 0, and `tax_amount` is set to any value, then there should be `line_items` param where the sum of taxes on these supplied line items should equal the supplied `tax_amount`, or otherwise a deprecation error will appear saying `passing in incorrect tax amounts is deprecated`.
- Given that these tests does not care if these line items are created or not, I just changed `skipLineItem` param to 1 and thus the comparison above won't happen.