search

compucorp / uk.co.compucorp.membershipextras

Membership Extras for CiviCRM
Other
5 stars 8 forks source link

MAE-1114: Fix The Extension Installation on some sites #517

Closed shahrukh-compuco closed 9 months ago

shahrukh-compuco commented 9 months ago

Overview

This PR fixes the extension installation on some sites.

Before

Previously the extension installation was failing if the EFT payment method was not there as the creation of manual payment processor was dependent on EFT payment method.

After

This PR changes the flow to first create a new payment by the name of Offline Automated Recurring method that manual payment processor will use instead of EFT

Technical Overview

We create a new payment method attached to default financial account of type Asset or the first financial account of type Asset if default financial account of type Asset is not present

omarabuhussein commented 9 months ago

hence that the tests are failing for a reason that is unrelated to the work in this PR, so if it passes testing we can merge it, I will need to look into these failed tests separately