Closed TMesot closed 3 years ago
Hello TMesot,
Thank you for locating the problem. Patch link will be provided.
Hi TMesot, Relevant patch: Fix mcp25xxfd driver compilation for !CONFIG_DEBUG_FS
Hello, Thanks for your reactivity.
It now build, but there is still a warning about unused variable as the priv struct is not used if DEBUG_FS not enabled :
drivers/net/can/spi/mcp25xxfd/mcp25xxfd_cmd.c: Dans la fonction « mcp25xxfd_cmd_readn_crc »:
drivers/net/can/spi/mcp25xxfd/mcp25xxfd_cmd.c:258:25: warning: variable inutilisée « priv » [-Wunused-variable]
struct mcp25xxfd_priv *priv = spi_get_drvdata(spi);
Do you want me to keep the issue open until the warning is cleaned ?
Hi TMesot,
Thank you again. Patch fixed.
Hello, Build is now fixed, thanks !
The tag
iot-gate-imx8_r2.2
introduce some new kernel patches, especially0042-can-mcp25xxfd-update-driver.patch
which seems not buildable with recommanded NXP release kernel (rel_imx_5.4.24_2.1.0) if CONFIG_DEBUG_FS is disabled (which is the case in most production definitions).Disabling
0042-can-mcp25xxfd-update-drive.patch
patch, while keeping the other new patches works.It seems the code strongly rely on the
stats
structure onmcp25xxfd_can_priv
structure which is not enabled if CONFIG_DEBUG_FS is disable