search

compulim / react-scroll-to-bottom

React container that will auto scroll to bottom
MIT License
183 stars 35 forks source link

Remove defaultProps (use default parameters) #134

Closed koteus closed 1 month ago

koteus commented 10 months ago

This fixes React warnings: "Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead."

ImLunaHey commented 6 months ago

@compulim any chance you could review this?

compulim commented 6 months ago

Sorry, my real world job is very busy recently. I will take a look at this as soon as I am freed up. 🙇🏻‍♂️

This is a very good move, getting rid of defaultProps.

I think @koteus spent some time thinking BasicScrollToBottomCore.initialScrollBehavior. This is the part I need to some reading time. Will be great if someone could speed me up on this.

koteus commented 6 months ago

Hi @compulim I think you mean the default value "smooth" for initialScrollBehavior, I provided it by using javascript default value for object destructuring syntax (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment#default_value)

Here is the line: https://github.com/compulim/react-scroll-to-bottom/blob/2d082ec12cecf9890ea14e93915eb7514e6249c9/packages/component/src/BasicScrollToBottom.js#L39

koteus commented 5 months ago

Hi @compulim is there anything I could do to help you review this PR?

codeXLinkX commented 4 months ago

thanks for working on this @koteus 🤝

ImLunaHey commented 4 months ago

hate to be that person but is there anything holding this back?

@compulim the code looks fine, if you can approve the CI this can be merged and a new release can be cut.

koteus commented 3 months ago

Hello 👋
Support for defaultProps in function components has been officially removed in React 19

https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops

Merging this PR will allow react-scroll-to-bottom to support React 19 (unless there are any other deprecated features). Right now React 19 is RC and stable release will probably be announced soon.

wong2 commented 3 months ago

Really hope this can be merged before React 19 release.

koteus commented 1 month ago

I rebased my PR on the latest main and I had to create a new PR because my this one was initiated from the main branch. During rebase I pressed "sync" and Github closed this PR, so please check out the new one https://github.com/compulim/react-scroll-to-bottom/pull/141