Open koteus opened 1 month ago
This is a rebased version of my previous PR https://github.com/compulim/react-scroll-to-bottom/pull/134 I had to open a new one because I opened it from the main
branch on my fork (my bad), and because another PR was merged (https://github.com/compulim/react-scroll-to-bottom/pull/137) I had trouble syncing my changes. Sorry for this compulim, and I hope this one will be moved forward and merged soon 🙏
Is there any progress about merging this one? I really need it
Is there any progress about merging this one? I really need it
If you really need it, you can use the branch as dependency, eg.
"react-scroll-to-bottom": "github:koteus/react-scroll-to-bottom#fix/remove-default-props",
in your package.json
I tried to install the branch but then got the following error:
[vite] Internal server error: Failed to resolve entry for package "react-scroll-to-bottom". The package may have incorrect main/module/exports specified in its package.json
Do you know why?
I tried to install the branch but then got the following error:
[vite] Internal server error: Failed to resolve entry for package "react-scroll-to-bottom". The package may have incorrect main/module/exports specified in its package.json
Do you know why?
hmm no, unfortunately I don't know why :/ gave a generic advice that works in most cases but seems the fork (or the library itself) may not work well with this workaround
@compulim is there anything we can help to get this reviewed and merged?
If it's helpful to anyone out there, for a project I work on I finally got annoyed enough to just use patch-package
to fix this.
Patch file: react-scroll-to-bottom+4.2.0.patch
Apologies for the size of it -- when my editor auto-formatted the files I was like ehhh whatevs.
I need this :)
i also need this : )
I made a smaller version of @josheverett patch.
react-scroll-to-bottom+4.2.0.patch
npm i patch-package --save-dev
react-scroll-to-bottom+4.2.0.patch
to new root folder patches
"postinstall": "patch-package"
to scripts
in package.json
npm ci
This fixes React warnings: "Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead."
Changelog
Specific changes