search

compulim / vscode-closetag

Quickly close last opened HTML/XML tag in Visual Studio Code
14 stars 5 forks source link

closeTag.closeHTMLTagInPlace is not working correctly in VS Code 1.13.1 #11

Open rbolsius opened 7 years ago

rbolsius commented 7 years ago

In the latest version of VS Code closeTag.closeHTMLTagInPlace does not behave any differently than closeTag.closeHTMLTag. Both commands place the cursor after the inserted tag in VS Code 1.13.1. closeTag.closeHTMLTagInPlace should keep the cursor before the inserted tag when the selection is empty.

compulim commented 6 years ago

Fixed in #12.

compulim commented 6 years ago

Released in 1.2.0.

rbolsius commented 6 years ago

Hi, it seems that the fix that was merged has some problems and does not actually keep the cursor inside the tag. I put some commends in PR https://github.com/compulim/vscode-closetag/pull/12 explaining what I think the issue is.

compulim commented 6 years ago

Thanks.

compulim commented 6 years ago

Pretty tight up on my real world job, will take a look asap. Good that we have Travis CI publish workflow setup so as soon as the PR is in, it will be on VSCE. 😉