compuphase / Black-Magic-Probe-Book

A guide plus associated utilities for the Black Magic Probe.
Apache License 2.0
147 stars 26 forks source link

Fixed windows bmp trace guid scanning #7

Closed Zagitta closed 4 years ago

Zagitta commented 4 years ago

On my windows machine find_bmp fails with TRACESTAT_NO_INTERFACE because the first subkey in the registry doesn't contain the somethingsomething/DeviceInterfaceGUIDs regkey and it bails out before scanning the other subkeys. This fixes that issue by continuing to scan the other subkeys. My registry looks like this: image Where 8&214b00d1&0&0005 (the second subkey) contains the expected Device Parameters\DeviceInterfaceGUIDs key while the other subkeys does not.

compuphase commented 4 years ago

Thank you for pointing this out. I fixed it in commit 685b5377474e610848131e1b596fd0558e800fe9, but slightly differently. The reason is that I want to prepare for the case that people have two probes attached to a workstation. So you should be able to find the GUID of both the first BMP and the second BMP (and the third, and so on). That is not working yet, but I try to prepare the code for that future functionality.