search

compupro / latin-annotator

A JS web app that annotates latin text and shows word agreement relationships
GNU General Public License v3.0
0 stars 0 forks source link

Show inflection/note bubble when hovering over words #12

Closed compupro closed 5 years ago

compupro commented 5 years ago

It can be helpful to not have to click on the word to view notes or inflection information, especially when you're looking at things that agree with a certain word that are all highlighted, but which will cease to be highlighted when you click away.

compupro commented 5 years ago

Progress on showing bubbles/tooltips on hover started on https://github.com/compupro/latin-annotator/commit/a8f13e46f5f8b472c467b90120fe9d4f5b789664

compupro commented 5 years ago

Tooltip does not currently show inflection or user-notes (the latter doesn't have any support yet)

compupro commented 5 years ago

Tooltip shows inflection table as of https://github.com/compupro/latin-annotator/commit/61a8d1dcff2c899bdce755364ecb79d51496c5f8 but is a little buggy.

Hovering over a word that does not have definitions grabbed by means of clicking will fail. This is because clicking on a word generates tables and displays them in the definitionContainer, but this doesn't happen when a tooltip requests definitions. The tooltip tries to display tables that haven't been generated yet, and the tooltip will fail to show until the word is clicked on. After that, the tooltip will work fine.

EDIT: This is false! It's actually trying to access the inflTable for the first word all the time! This is now the case as of https://github.com/compupro/latin-annotator/commit/659acb9f7a77d7b63122f735d3858c032854e90d

I want to separate the table generation logic into its own function so it can be accessed by different things without causing ancillary behavior

Also the table is green in the tooltip, which is dumb.

compupro commented 5 years ago

Table generation reworked in https://github.com/compupro/latin-annotator/commit/11b398c779e8ec836b222cde2244e3589b5e39b6 and tables in tooltips work properly as of https://github.com/compupro/latin-annotator/commit/981fa7ea913f7789cb5cdd94180f81f100309b88

Still green, but it's functional.

compupro commented 5 years ago

Closing this issue and making the thing about the unimplemented notes feature its own issue https://github.com/compupro/latin-annotator/issues/18