compupro / latin-annotator

A JS web app that annotates latin text and shows word agreement relationships
GNU General Public License v3.0
0 stars 0 forks source link

The app thinks everything is the same word when you submit the same Latin passage more than once #37

Closed compupro closed 5 years ago

compupro commented 5 years ago

I submitted some latin text, clicked on it a bit, then submitted the same latin text. Lo and behold it thought everything was "sum" for some reason.

Tested using the phrase "Ego sum in horto. Hortus me valde placet." on Chrome

compupro commented 5 years ago

When you submit the same phrase twice, it will think all the words are the same word.

compupro commented 5 years ago

At some point the words' definitions get completely replaced by the definition of the word accessed last

compupro commented 5 years ago

Possibly related: when you click on a word, it keeps adding tables to its definition.inflTables

compupro commented 5 years ago

Fixed in https://github.com/compupro/latin-annotator/commit/d92296cedb587b6c5be6161d554fc33db36eaff1

Apparently inside getWordDefinitions(kwArgs) it was calling this.afterFetching(definition, kwArgs); but definition wasn't set to anything which was causing strange behavior.