Verb agreement doesn't check for person

compupro / latin-annotator

A JS web app that annotates latin text and shows word agreement relationships

GNU General Public License v3.0

0 stars 0 forks source link

Verb agreement doesn't check for person #4

Closed compupro closed 5 years ago

compupro commented 5 years ago

Second and first person agree with 3rd person nominative nouns even though they shouldn't. Will need to introduce some kind of special checking against a list of approved pronouns instead.

compupro commented 5 years ago

Done in https://github.com/compupro/latin-annotator/commit/b140fdb176238bea3b358975977c0b45afe729a3

EDIT: didn't use an approved pronoun list, instead supplying a person attribute in the definition of pronouns when its definition is acquired.

compupro commented 5 years ago

I think the agreement logic is wrong in some way but I don't have time to review it today.

compupro commented 5 years ago

Apparently it was checking for 3rd person attributes of nouns which are not injected with a Person attribute (since it is assumed that nouns are 3rd person unless otherwise specified)