search

computablee / DotMP

A collection of powerful abstractions for parallel programming in .NET with an OpenMP-like API.
https://computablee.github.io/DotMP/
GNU Lesser General Public License v2.1
29 stars 7 forks source link

Chore: Remove dead code #53

Closed blouflashdb closed 1 year ago

blouflashdb commented 1 year ago

Closes #50

computablee commented 1 year ago

The tests are not passing, but it looks like it's because the tests rely on the old behavior of critical (i.e., the return value from critical is not simply the ID passed in; it was the number of criticals that have been encountered. I've converted the PR to a draft and will fix the unit tests, but the change looks good so I have approved it and will merge once I get the tests fixed.

computablee commented 1 year ago

Got the tests passing. Approved, thank you for the contribution!