search

computablelabs / goest

Golang testing and sandbox for the Computable Protocol. 0xb00.
MIT License
8 stars 0 forks source link

Check for zero address in setPrivileged #131

Closed rbharath closed 5 years ago

rbharath commented 5 years ago

The setPrivileged function in MarketToken.vy and Voting.vy should check that its argument addresses are not ZERO_ADDRESS. It is not semantically valid to set these to ZERO_ADDRESS so the additional check will prevent accidental errors.

robrobbins commented 5 years ago

Hmm. I am coding this up. I am not convinced it means anything.

Yes, it is incorrect that it's possible to call these with 0x0000. This "fix" would stop that. However You could also call these with completely incorrect addresses and fuck up your whole market. There is no fix in the world for that (that i would implement). In that case you must re-deploy the entire set of contracts. So. I don't see any real value in putting in a fix for an error that can be corrected vs leaving one that cannot. This is meaningless and likely to get a No from me. < discuss >

robrobbins commented 5 years ago

not doing.