search

computational-seismology / pyadjoint

Python package to measure misfits and calculate adjoint sources
http://krischer.github.io/pyadjoint/
BSD 3-Clause "New" or "Revised" License
3 stars 10 forks source link

dt_sigma_min missing from config list #5

Closed wjlei1990 closed 8 years ago

wjlei1990 commented 8 years ago

This variable is used in cc_traveltime.config, but not listed in Config object.

wjlei1990 commented 8 years ago

Config object could be better organised.

Defining unnecessary variables to accommodate different measurements is a bad idea, will cause potential bugs in the future.

Solutions: 1) define a parent(or super) class ConfigBase and child class for different measurements. 2) directly define different Config classes for different measurements.

chukren commented 8 years ago

Thanks, I agree. This is the latest updates which not reflected in pytomo3d yet. I think I will go with a different Config class for each type of measurement so the future users can have more flexibility to add their own type of adjoint sources

chukren commented 8 years ago

dev branch has been merged to master and will be removed. All to do list will be transferred to master branch.