search

computational-seismology / pypaw

PYthon Process Asdf Wokflow, in short for, pypaw
https://computational-seismology.github.io/pypaw/
GNU Lesser General Public License v3.0
3 stars 6 forks source link

check_events_consistent does not return a value #14

Closed rdno closed 7 years ago

rdno commented 7 years ago

Hi Wenjie,

In window_weights.py:L136 you check for event consistency but the function in pytomo3d does not return a value. Thus, if condition throws an error because None has no length. In the recent update of pytomo3d, you check the same condition in the function itself (link). The check probably is not needed here anymore :)

wjlei1990 commented 7 years ago

Good catch. Sorry for the late response because of Thanksgiving :)