search

computational-seismology / pypaw

PYthon Process Asdf Wokflow, in short for, pypaw
https://computational-seismology.github.io/pypaw/
GNU Lesser General Public License v3.0
3 stars 6 forks source link

pypaw requires an older version of obspy #19

Closed rmodrak closed 6 years ago

rmodrak commented 6 years ago

This is a temporary fix so that Carl's group can use your tools. In the long run you'll either need to stop maintaining separate forks of Lion's packages, or else be prepared for repeated compatibility issues of this type.

mpbl commented 6 years ago

Good point. @wjlei1990, @chukren: Is there any issue to merge back our forks into Lion's main repo? I believe Ryan is talking about pypaw and pyflex.

wjlei1990 commented 6 years ago

1) pypaw is our own package. So we need to maintain by ourselves.

2) pyflex...It is a long story. I put a pull request two years ago. https://github.com/krischer/pyflex/pull/7

I will discuss with Lion about it.

wjlei1990 commented 6 years ago

I checked the issue. It is mainly pyflex causing the problem since it is using some very old APIs from obsolete obspy. I will work with Lion first to merge the pyflex.

rmodrak commented 6 years ago

Exactly, your forks use obspy functions that were deprecated and are now fully removed. In most cases the fix involves changing a function or variable name. Lion has made these compatibility fixes in pyflex and pyadjoint, but as long as you maintain separate forks you won't get his fixes.

mpbl commented 6 years ago

@wjlei1990 Sorry I meant pyadjoint, not pypaw...