Should we change the 'silent fail' if the system doesn't reach a relaxed state in max_steps?

computationalmodelling / fidimag

Finite DIfference microMAGnetic code, based on Python, Cython and C

http://computationalmodelling.github.io/fidimag/

Other

60 stars 24 forks source link

Should we change the 'silent fail' if the system doesn't reach a relaxed state in max_steps? #118

Open rpep opened 6 years ago

rpep commented 6 years ago

We could raise an exception if the system fails to relax if it hasn't reached stopping_dmdt in under max_steps. At the moment, we 'silently fail' which is not a great idea; it means that a user might think the system has relaxed when it has not.