computationalmodelling / fidimag

Finite DIfference microMAGnetic code, based on Python, Cython and C
http://computationalmodelling.github.io/fidimag/
Other
60 stars 24 forks source link

Make fidimag great again #138

Open rpep opened 5 years ago

rpep commented 5 years ago

Not ready to merge; just for test running.

The motivation behind this:

fangohr commented 5 years ago

The title of the merge request is hilarious. Keep going :)

davidcortesortuno commented 3 years ago

I'd make the RK4 arrays sequential to make the memory layout more compact, so something like (this won't compile I think, needs more thought)

class Integrator {
Integrator(size_t N) = 0; // No constructor so people can't use the base class
public:
...
};

The compiler gives me an error where the base class constructor is not virtual so I can't make = 0 to the constructor.

davidcortesortuno commented 11 months ago

We should not close this PR. But I'm not sure if someone would like to keep developing this full C backend, it's a lot of work :O