search

computationalmodelling / nbval

A py.test plugin to validate Jupyter notebooks
Other
438 stars 50 forks source link

Remove Python 2.7 and 3.5 #162

Closed gliptak closed 3 years ago

gliptak commented 3 years ago

Signed-off-by: Gábor Lipták gliptak@gmail.com

https://github.com/computationalmodelling/nbval/issues/160

vidartf commented 3 years ago

We should probably remove any py2 specific bits from the codebase too then, i.e. any use of six.

gliptak commented 3 years ago

@vidartf removed six

vidartf commented 3 years ago

Thanks. This code in plugin.py is also py2 specific, I think that would be the last bits:

from __future__ import print_function

# ... and

try:
    from Queue import Empty
except:
    from queue import Empty

(https://stackoverflow.com/questions/56047277/python-queue-vs-queue)

takluyver commented 3 years ago

Thanks!